Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/update mint nft doc #1653

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Docs/update mint nft doc #1653

merged 8 commits into from
Aug 5, 2024

Conversation

vivekjain23
Copy link
Contributor

Update the Mint NFT doc

  • This PR brings up the changes of updating the mint NFT doc according to our style-guide

Fixing the issue :

Type of change

  • Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@lucas-tortora lucas-tortora marked this pull request as draft July 24, 2024 13:40
@lucas-tortora lucas-tortora marked this pull request as ready for review July 24, 2024 13:40
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9a71d5f

✅ Preview: https://iota-wiki-8yijgh9bj-iota1.vercel.app

lucas-tortora
lucas-tortora requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement :)

docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/mint-nft.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/mint-nft.md Show resolved Hide resolved
@vivekjain23 vivekjain23 mentioned this pull request Jul 27, 2024
Open
@lucas-tortora lucas-tortora requested a review from a team July 30, 2024 13:04
@vivekjain23 @lucas-tortora
Update hyperlink
d731892 
Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com>
@vivekjain23 vivekjain23 requested a review from Ginowine July 31, 2024 06:20
@vivekjain23 vivekjain23 self-assigned this Jul 31, 2024
Ginowine
Ginowine approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Ginowine Ginowine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Dr-Electron Dr-Electron merged commit fed24e3 into main Aug 5, 2024
9 checks passed
@Dr-Electron Dr-Electron deleted the docs/update-mint-nft-doc branch August 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

@Ginowine Ginowine Ginowine approved these changes

Assignees

@vivekjain23 vivekjain23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivekjain23 @Ginowine @salaheldinsoliman @Dr-Electron @lucas-tortora