feat(protocol): PCR-2 fixed base fee #3517

cyberphysic4l · 2024-10-21T15:21:49Z

DON'T REVIEW. THIS IS STILL A DRAFT, JUST RUNNING THE CI.

Description of change

Introduce a feature flag fixed_base_fee
Modify reference gas price based on protocol config
update the IotaSystemState and associated types to V2 to include a computation_charges_burned field.
update the iota_system move code advance_epoch function to burn base fee and pass additional fee to validators.

Links to any relevant issues

Fixes #3122
Fixes #4114

Type of change

Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

crates/iota-core/src/authority.rs

crates/iota-single-node-benchmark/src/single_node.rs

…urned`

… state

…osts-burned' into protocol/pcr2

cyberphysic4l · 2024-11-14T17:20:58Z

crates/iota-types/src/gas_model/gas_v1.rs

        fn bucketize_computation(&mut self) -> Result<(), ExecutionError> {
-            let gas_used = self.gas_status.gas_used_pre_gas_price();
-            let gas_used = if let Some(gas_rounding) = self.gas_rounding_step {
-                if gas_used > 0 && gas_used % gas_rounding == 0 {
-                    gas_used * self.gas_price
-                } else {
-                    ((gas_used / gas_rounding) + 1) * gas_rounding * self.gas_price
+            let mut computation_units = self.gas_status.gas_used_pre_gas_price();
+            if let Some(gas_rounding) = self.gas_rounding_step {
+                if computation_units == 0 || computation_units % gas_rounding > 0 {
+                    computation_units = ((computation_units / gas_rounding) + 1) * gas_rounding;
                }
            } else {
-                let bucket_cost = get_bucket_cost(&self.cost_table.computation_bucket, gas_used);
-                // charge extra on top of `computation_cost` to make the total computation
-                // cost a bucket value
-                bucket_cost * self.gas_price
+                computation_units = get_bucket_cost(&self.cost_table.computation_bucket, computation_units);
            };
-            if self.gas_budget <= gas_used {
+            let computation_cost = computation_units * self.gas_price;
+            if self.gas_budget <= computation_cost {
                self.computation_cost = self.gas_budget;
                Err(ExecutionErrorKind::InsufficientGas.into())
            } else {
-                self.computation_cost = gas_used;
+                self.computation_cost = computation_cost;
                Ok(())


@vekkiokonio please review. The logic should be unchanged here, I just wanted to make the distinction between computation units and computation cost (in Nanos) more clear.

github-actions · 2024-11-28T12:04:24Z

This pull request has been deployed to Vercel.

Latest commit: ad897c6

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-50ajtfdi2.vercel.app

github-actions · 2024-11-28T12:04:49Z

This pull request has been deployed to Vercel.

Latest commit: ad897c6

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-e473gxuds.vercel.app

miker83z · 2024-11-28T12:20:47Z

crates/iota-types/src/gas_model/gas_v2.rs

+        /// remaining gas and storage cost to derive computation cost.
+        fn summary(&self) -> GasCostSummary {
+            // compute computation cost burned and storage rebate, both rebate and non refundable fee
+            let computation_cost_burned = self.computation_cost * self.reference_gas_price / self.gas_price;


If this is the only change, then we don't need gas_v2. Maybe an if fixed_base_fee in gas_v1 would be sufficient

@cyberphysic4l pls, check also this!

I have reverted the addition of gas_v2, and in fact I don't think we even need an if fixed_base_fee because the computation_cost_burned field is actually unused in protocol v1, so it doesn't matter what we set for this value. So we avoid an additional if statement here.

github-actions · 2024-11-28T12:31:04Z

This pull request has been deployed to Vercel.

Latest commit: f6e3013

✅ Preview: https://apps-ui-kweelww3q-iota1.vercel.app

github-actions · 2024-11-28T12:31:08Z

This pull request has been deployed to Vercel.

Latest commit: f6e3013

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-3d6hav69s.vercel.app

github-actions · 2024-11-28T12:31:34Z

This pull request has been deployed to Vercel.

Latest commit: f6e3013

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-8um4hyami.vercel.app

github-actions · 2024-11-28T12:31:45Z

This pull request has been deployed to Vercel.

Latest commit: f6e3013

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3lasjz1fp.vercel.app

github-actions · 2024-11-28T14:23:39Z

This pull request has been deployed to Vercel.

Latest commit: ff78bba

✅ Preview: https://apps-ui-8qik7ktch-iota1.vercel.app

github-actions · 2024-11-28T14:24:00Z

This pull request has been deployed to Vercel.

Latest commit: ff78bba

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-b1h0xflo4.vercel.app

github-actions · 2024-11-28T14:24:04Z

This pull request has been deployed to Vercel.

Latest commit: ff78bba

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-gric8feol.vercel.app

github-actions · 2024-11-28T14:24:26Z

This pull request has been deployed to Vercel.

Latest commit: ff78bba

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-b7tz7ikcc.vercel.app

valeriyr · 2024-11-28T14:48:56Z

iota-execution/latest/iota-adapter/src/execution_engine.rs

        ];
        let call_arg_arguments = vec![
+            CallArg::Pure(bcs::to_bytes(&params.computation_charge_burned).unwrap()),


If it is the only change in the executor we can consider options instead of creating a new execution layer cut, for example:

Create a new transaction type EndOfEpochTransactionKind::ChangeEpochV2.

Or even easier, add a feature flag in the protocol config advance_epoch_v2, set it to true for the second protocol version, and add the computation_charge_burned parameter if it is enabled.

Creating a cut adds a pretty noticeable amount of code to the repository and should be avoided if it is possible, I believe. Because this increases the repository size and build time.

I think too we can definitively try avoid the use of a new cut!

Ok, if that is the preferred approach I can try one of the suggested alternatives.

This reverts commit 16d8c52.

github-actions · 2024-11-29T11:30:11Z

This pull request has been deployed to Vercel.

Latest commit: 30285b6

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-dkym5ydp6.vercel.app

github-actions · 2024-11-29T11:30:18Z

This pull request has been deployed to Vercel.

Latest commit: 30285b6

✅ Preview: https://apps-ui-pmt2eihoj-iota1.vercel.app

github-actions · 2024-11-29T11:31:00Z

This pull request has been deployed to Vercel.

Latest commit: 30285b6

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-hdefaofc7.vercel.app

github-actions · 2024-11-29T11:31:13Z

This pull request has been deployed to Vercel.

Latest commit: 30285b6

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-aloepm8kk.vercel.app

github-actions · 2024-11-29T12:03:37Z

This pull request has been deployed to Vercel.

Latest commit: c2d9200

✅ Preview: https://apps-ui-mt0fnemg2-iota1.vercel.app

github-actions · 2024-11-29T12:03:53Z

This pull request has been deployed to Vercel.

Latest commit: c2d9200

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-fb0szzkxq.vercel.app

github-actions · 2024-11-29T12:04:19Z

This pull request has been deployed to Vercel.

Latest commit: c2d9200

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1kfjg7tnt.vercel.app

github-actions · 2024-11-29T12:04:35Z

This pull request has been deployed to Vercel.

Latest commit: c2d9200

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-rd8itbhwj.vercel.app

alexsporn added the tokenomics Issues related to tokenomics and gas price modulation label Oct 22, 2024

begonaalvarezd mentioned this pull request Oct 22, 2024

Update tooling related after fixed gas price protocol changes #3536

Open

introduce feature flag for fixed base fee

012b96b

cyberphysic4l force-pushed the protocol/pcr2 branch from a14717f to 012b96b Compare October 22, 2024 11:21

cyberphysic4l and others added 2 commits October 22, 2024 16:06

target_rewards -> subsidy and computation_reward -> computation_charge

cde1017

Edit feature flag for fixed_based_fee

1183df6

vekkiokonio reviewed Oct 24, 2024

View reviewed changes

crates/iota-core/src/authority.rs Outdated Show resolved Hide resolved

vekkiokonio reviewed Oct 24, 2024

View reviewed changes

crates/iota-single-node-benchmark/src/single_node.rs Outdated Show resolved Hide resolved

vekkiokonio assigned vekkiokonio and cyberphysic4l Oct 24, 2024

vekkiokonio added the research label Oct 24, 2024

vekkiokonio mentioned this pull request Oct 24, 2024

[Task (gas-price-modulation-tf)] Implement a fixed protocol-based gas price #3122

Open

vekkiokonio added 2 commits October 24, 2024 16:21

Modified reference_gas_price() based on protocol config

136f9d2

Add base_gas_price to AdvanceEpochParams

ee906cf

vekkiokonio linked an issue Oct 25, 2024 that may be closed by this pull request

[Task (gas-price-modulation-tf)] Implement a fixed protocol-based gas price #3122

Open

cyberphysic4l and others added 8 commits November 4, 2024 17:35

Merge branch 'develop' into protocol/pcr2

b6c19da

set fixed_base_fee flag to false in snapshot

f7da081

feat(analytics-indexer): add computation_cost_burned

8db722a

feat(core-node): add computation_cost_burned to ChangeEpoch

f7f6c01

feat(indexer): add computation_cost_burned to checkpoints

824dd92

feat(core-node): add asserts and debug prints for `computation_cost_b…

e2439ee

…urned`

feat(core-node): add safe_mode_computation_rewards_burned to system…

a9b381e

… state

feat(framework): update framework-snapshot manifest

3f2e043

muXxer mentioned this pull request Nov 11, 2024

Add computation_cost_burned and safe_mode_computation_rewards_burned fields #4008

Draft

6 tasks

cyberphysic4l added 5 commits November 12, 2024 11:30

Merge branch 'develop' into protocol/pcr2

6330fd1

start adding computation_charge_burned to change epoch

db09094

Merge remote-tracking branch 'origin/core-node/feat/add-computation-c…

fc2ec23

…osts-burned' into protocol/pcr2

implement advance_epoch changes for base fee burning

874df21

generate gas cost summary correctly with fixed base fee flag

7c93a95

cyberphysic4l commented Nov 14, 2024

View reviewed changes

miker83z reviewed Nov 28, 2024

View reviewed changes

rustfmt

f6e3013

cyberphysic4l added 2 commits November 28, 2024 14:17

clippy lint

9270ed8

Merge branch 'develop' into protocol/pcr2

ff78bba

valeriyr reviewed Nov 28, 2024

View reviewed changes

cyberphysic4l added 3 commits November 28, 2024 16:18

fix pt_fuzz test

e10b51a

remove need for gas_v2 and adapter cut v1

568c3da

Revert "create v1 cut of adapter using script"

30285b6

This reverts commit 16d8c52.

cyberphysic4l requested review from a team as code owners November 29, 2024 11:25

cyberphysic4l added 2 commits November 29, 2024 11:41

fix iota-framework

f21f897

update v2 framework snapshot

c2d9200

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(protocol): PCR-2 fixed base fee #3517

feat(protocol): PCR-2 fixed base fee #3517

cyberphysic4l commented Oct 21, 2024 •

edited

Loading

cyberphysic4l Nov 14, 2024

miker83z Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

miker83z Nov 28, 2024

miker83z Nov 28, 2024

cyberphysic4l Nov 29, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

valeriyr Nov 28, 2024 •

edited

Loading

miker83z Nov 28, 2024

cyberphysic4l Nov 28, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

feat(protocol): PCR-2 fixed base fee #3517

Are you sure you want to change the base?

feat(protocol): PCR-2 fixed base fee #3517

Conversation

cyberphysic4l commented Oct 21, 2024 • edited Loading

DON'T REVIEW. THIS IS STILL A DRAFT, JUST RUNNING THE CI.

Description of change

Links to any relevant issues

Type of change

How the change has been tested

Change checklist

cyberphysic4l Nov 14, 2024

Choose a reason for hiding this comment

miker83z Nov 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

miker83z Nov 28, 2024

Choose a reason for hiding this comment

miker83z Nov 28, 2024

Choose a reason for hiding this comment

cyberphysic4l Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

valeriyr Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

miker83z Nov 28, 2024

Choose a reason for hiding this comment

cyberphysic4l Nov 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

cyberphysic4l commented Oct 21, 2024 •

edited

Loading

valeriyr Nov 28, 2024 •

edited

Loading