Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(move/examples): implementation of kiosk marketplace extension using kiosk rules #4156

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

Dkwcs
Copy link
Contributor

@Dkwcs Dkwcs commented Nov 20, 2024

Description of change

New Kiosk extensions have been added in order to demonstrate practical usage of some Kiosk features(extensions, rules, transfer policies).

Links to any relevant issues

Fix #3997 .

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Read https://github.com/iotaledger/iota/pull/4156/files#diff-ed4b688332b92ef7cc237545e28cac0a73f64d2e509737d8e95cc72a6b82831d

@Dkwcs Dkwcs added the vm-language Issues related to the VM & Language Team label Nov 20, 2024
@Dkwcs Dkwcs self-assigned this Nov 20, 2024
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example! What do you think about creating a documentation page with the text of the README?

docs/examples/move/nft_marketplace/README.md Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Outdated Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Show resolved Hide resolved
@Dkwcs Dkwcs marked this pull request as ready for review November 26, 2024 13:14
@Dkwcs Dkwcs requested a review from a team as a code owner November 26, 2024 13:14
@Dkwcs Dkwcs requested review from valeriyr, nonast and a team November 26, 2024 13:14
Copy link

✅ Vercel Preview Deployment is ready!

View Preview

Copy link

✅ Vercel Preview Deployment is ready!

View Preview

Copy link

✅ Vercel Preview Deployment is ready!

View Preview

Dkwcs and others added 2 commits November 27, 2024 16:59
Co-authored-by: Mirko Zichichi <miker83z@proton.me>
Co-authored-by: Mirko Zichichi <miker83z@proton.me>
Copy link

✅ Vercel Preview Deployment is ready!

View Preview

@Dkwcs Dkwcs changed the title feat(move/examples): draft of kiosk nft marketplace using kiosk rules feat(move/examples): implementation of kiosk marketplace extension using kiosk rules Nov 27, 2024
Copy link

✅ Vercel Preview Deployment is ready!

View Preview

docs/examples/move/nft_marketplace/README.md Outdated Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Outdated Show resolved Hide resolved
docs/examples/move/nft_marketplace/README.md Outdated Show resolved Hide resolved
### 5. Create a Transfer Policy

`TransferPolicy` is a generic shared object acting as a central authority enforcing everyone to check their purchase is valid against the defined policy before the purchased item is transferred to the buyers. Object is specified by concrete type.
`default` function creates `TransferPolicy` object and an OwnerCap, then transferring them to the caller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be:
a TransferPolicy object and a TransferPolicyCap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s a description of TransferPolicy itself we don’t have to focus on TransferPolicyCap
But below, in the description I’ve admitted that we have to import TransferPolicyCap too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear what the OwnerCap is. It is better to clarify because I can't find such a type or explanation to this entity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short description of TransferPolicyCap has been added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you leave the OwnerCap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/examples/move/nft_marketplace/README.md Show resolved Hide resolved
Copy link

✅ Vercel Preview Deployment is ready!

View Preview

Copy link

✅ Vercel Preview Deployment is ready!

View Preview

Copy link

✅ Vercel Preview Deployment is ready!

View Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm-language Issues related to the VM & Language Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kiosk] Create an example NFT marketplace using the Kiosk framework, document it and suggest improvements
3 participants