-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(move/examples): implementation of kiosk marketplace extension using kiosk rules #4156
base: develop
Are you sure you want to change the base?
feat(move/examples): implementation of kiosk marketplace extension using kiosk rules #4156
Conversation
… separately from the marketplace extension and added some mock items for marketplace operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good example! What do you think about creating a documentation page with the text of the README?
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/item_for_market.move
Outdated
Show resolved
Hide resolved
Co-authored-by: Mirko Zichichi <miker83z@proton.me>
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
Co-authored-by: Mirko Zichichi <miker83z@proton.me>
Co-authored-by: Mirko Zichichi <miker83z@proton.me>
✅ Vercel Preview Deployment is ready! |
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
✅ Vercel Preview Deployment is ready! |
### 5. Create a Transfer Policy | ||
|
||
`TransferPolicy` is a generic shared object acting as a central authority enforcing everyone to check their purchase is valid against the defined policy before the purchased item is transferred to the buyers. Object is specified by concrete type. | ||
`default` function creates `TransferPolicy` object and an OwnerCap, then transferring them to the caller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be:
a TransferPolicy
object and a TransferPolicyCap
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it’s a description of TransferPolicy
itself we don’t have to focus on TransferPolicyCap
But below, in the description I’ve admitted that we have to import TransferPolicyCap
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear what the OwnerCap
is. It is better to clarify because I can't find such a type or explanation to this entity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short description of TransferPolicyCap
has been added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you leave the OwnerCap
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
✅ Vercel Preview Deployment is ready! |
Description of change
New Kiosk extensions have been added in order to demonstrate practical usage of some Kiosk features(extensions, rules, transfer policies).
Links to any relevant issues
Fix #3997 .
Type of change
How the change has been tested
Read https://github.com/iotaledger/iota/pull/4156/files#diff-ed4b688332b92ef7cc237545e28cac0a73f64d2e509737d8e95cc72a6b82831d