fix(iota-indexer): fix failing test #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiupopescu199
added
sc-platform
samuel-rufi
reviewed
Nov 21, 2024
sergiupopescu199
force-pushed
the
sc-platform/issue-4171
branch
from
16250e7 to
f453e58
Compare
sergiupopescu199
force-pushed
the
sc-platform/issue-4171
branch
from
db8df38 to
9afef06
Compare
kodemartin
reviewed
Nov 26, 2024
kodemartin
reviewed
Nov 26, 2024
Thoralf-M
reviewed
Nov 26, 2024
Thoralf-M
approved these changes
Nov 26, 2024
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
alexsporn
approved these changes
Nov 27, 2024
alexsporn
pushed a commit
that referenced
this pull request
Nov 28, 2024
* fix(iota-indexer): fix failing test * fixup! fix(iota-indexer): fix failing test * fixup! fixup! fix(iota-indexer): fix failing test * fixup! fixup! fixup! fix(iota-indexer): fix failing test * fix(*): add rest api sync flag * fix(*): fallback to rest api * Update crates/iota-indexer/src/test_utils.rs Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * fixup! fix(*): fallback to rest api --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
alexsporn
pushed a commit
that referenced
this pull request
Nov 28, 2024
* fix(iota-indexer): fix failing test * fixup! fix(iota-indexer): fix failing test * fixup! fixup! fix(iota-indexer): fix failing test * fixup! fixup! fixup! fix(iota-indexer): fix failing test * fix(*): add rest api sync flag * fix(*): fallback to rest api * Update crates/iota-indexer/src/test_utils.rs Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * fixup! fix(*): fallback to rest api --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In indexer's tests don't use the
data_ingestion_pathfor checkpoint sync but fallback to the full node's REST APILinks to any relevant issues
fixes #4171
Type of change
How the change has been tested
Locally this test never fails, the actual test will be to check if on CI is does not fail
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.