This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Fix: Correct walker behaviour for alpha == 0 #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
reviewed
Oct 30, 2019
| @@ -128,7 +128,7 @@ public Hash walk(Hash entryPoint, Map<Hash, Integer> ratings, WalkValidator walk | |||
| int approverIndex; | |||
|
|
|||
| //Check if ratings map is empty. If so, alpha was set to 0 and a random approver will be selected. | |||
There was a problem hiding this comment.
Youre probably going to stab me once or twice, but the comment above it is now wrong :)
kwek20
changed the title
GalRogozinski
approved these changes
Dec 3, 2019
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the walker uses an
if(!Collections.EMPTY_MAP.equals(ratings))check to determine if the alpha value is 0 in the walker. But since the ratings list is is provided byratingOnethis list is not empty. Therefore the node is still performing the walk as though the alpha is not 0. The improved behaviour from not doing the ratings calculation has been the result of the alpha 0 change, but having the walk skip the additional unnecessary calculations on the walk end should show another improvement to response time.Type of change
How Has This Been Tested?
-Set a break point in the walker to make sure that the walk is registering the correct alpha value and using the correct logic
Checklist: