This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihardsgravis
added
Feature
New feature or request
Browser
Browser and PWA application related issues
UI/UX
User Interface related issues
labels
Dec 13, 2019
rihardsgravis
changed the title
Add payment browser notification
Add payment browser notifications
Dec 13, 2019
Somebody brought up native notifications at tauri yesterday: |
Awesome @nothingismagick! I was also looking into https://docs.rs/notify/5.0.0-pre.1/notify/ as an option for the desktop version. But if it's added to Tauri core - even better 🎉 |
We're working hard to launch the alpha this month - just one last tricky bit to solve. Its good to know that spark could consume it - so we'd have a smoke-test basically ready to go. |
* master: chore: update @iota/account package to 1.0.0-beta.25 Fix locale typo Switch to Typescript tests - Update layouts max-width - Limit Amount input minimum value to 0 - Add transaction input link hover color - Update SeedVault minimum password length to 8 chars fix: update "choose password" description fix: do not attempt to destroy scanner object if it has already been destroyed chore: remove unnecessary log fix: make sure outgoing transactions are displayed under "Sent" tab fix: check for null values before accessing marketPrice.currency prop Add missing request amount checks Add an error message if address generation fails chore(readme): use yarn not npm chore: bump @iota packages Add missing helpers tests
# Conflicts: # src-ui/lib/account.ts
cvarley100
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If supported by the browser, show notifications for incoming and outgoing transactions .