Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Cleanup #166

Merged
merged 20 commits into from
Mar 19, 2021
Merged

Beta Cleanup #166

merged 20 commits into from
Mar 19, 2021

Conversation

tensor-programming
Copy link
Contributor

@tensor-programming tensor-programming commented Mar 15, 2021

Description of change

PR for the Beta Cleanup

Links to any relevant issues

#160

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks cleaner!

@tensor-programming tensor-programming marked this pull request as ready for review March 18, 2021 07:39
nothingismagick and others added 12 commits March 18, 2021 10:13
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
see #172

Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
@nothingismagick nothingismagick mentioned this pull request Mar 19, 2021
Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com>
@nothingismagick nothingismagick merged commit dae0457 into dev Mar 19, 2021
@nothingismagick nothingismagick deleted the feat/beta-cleanup branch March 19, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants