Snapshot migration v3age 2.0 #474
Conversation
| let (data1, data2) = self.get_shards_data()?; | ||
| let data1 = &blake2b::Blake2b256::digest(data1); | ||
| let reconstructed_data = xor(data1, &data2, NC_DATA_SIZE); | ||
| let (r, mut m) = self.get_shards_data()?; |
There was a problem hiding this comment.
more descriptive variables?
There was a problem hiding this comment.
We've discussed this. See #474 (comment). Do you have suggestions?
There was a problem hiding this comment.
No, because I don't know what this code does (because the variables aren't descriptive)
There was a problem hiding this comment.
So we're just not gonna change this?
| .try_into() | ||
| .map_err(|_| FatalProcedureError::from("bad slip10 extended secret key size".to_owned()))?; | ||
| slip10::ExtendedSecretKey::try_from_extended_bytes(self.curve, ext_bytes) | ||
| .and_then(|parent| parent.derive(&self.chain)) | ||
| match self.curve { |
There was a problem hiding this comment.
Would it be too much to add a generic key type to the Slip10Derive rather than have Curve?
There was a problem hiding this comment.
Yes, actually. First, hazmat traits are inaccessible because hazmat module is private. Second, it's common for stronghold to have runtime types (see KeyType and AeadCipher enums, GenerateKey and PublicKey procedures). We can make hazmat module public in iota-crypto-0.20.1, but it would be difficult to completely fix stronghold.
Description of change
This PR fixes a number of issues in stronghold including insecure snapshot encryption format is replaced with password-based age-encryption.org/v1 format, secrets leaked into stack/heap memory are now zeroized after use.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #.Type of change
How the change has been tested
Tests now take longer due to secure password-based key derivation which should take approx 1 second on a modern computer. To alleviate it in tests set work_factor parameter to 1 in snapshot encryption routines.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.