chore(communication): bump libp2p version #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaf9
force-pushed
the
chore/libp2p-version
branch
from
f6f28a6
to
43aba0b
Compare
| @@ -377,8 +377,9 @@ mod test { | |||
| { | |||
| self.has_received_response = true; | |||
| } else if let CommunicationEvent::ConnectPeerResult { addr: _, result } = msg { | |||
| let peer_id = result.expect("Panic due to no network connection"); | |||
There was a problem hiding this comment.
Nice one. I assume this resolves the issue I faced with little-snitch blocking...
There was a problem hiding this comment.
The thing is that this test can only be successful if the process can use localhost, so if little-snitch is preventing that, it is correct that this should panic. But at least there is now a proper error message on that, if we want to handle this in a better way, I will have to either add a flag or some sort of delay to give little-snitch the time to allow it.
nothingismagick
approved these changes
Dec 18, 2020
|
Can you add a .changes file @elenaf9 ? |
nothingismagick
added a commit
that referenced
this pull request
Dec 24, 2020
* use btree and serialize client. * clean up cosmetics. * move and expose location. * fix bench and add read. * add init and create benches. * fix cli. * fix(tests): don't run them all all the time (#76) * fix(tests): don't run them all all the time * fix(workflow): test, not build and test * Unify API and harden client. (#78) * use btree and serialize client. * clean up cosmetics. * move and expose location. * fix bench and add read. * add init and create benches. * fix cli. * fix(covector) (#79) Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * fix covector (#81) Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * fix(covector) (#82) * fix(covector) (#83) * fix(covector): cargo.toml styles (#85) Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * fix counter logic. * add reference changes. * add multi-actor example. * test reading snapshot into a new actor. * allow new actor to read old snapshot. * cleanup. * fix errors. * fix return error. * remove lifetimes. * fix benchmark. * fix switch. * remove runtime. * fix location api. * clippity clip clip. * chore(communication): bump libp2p version (#88) * chore(communication): bump libp2p version * chore(communication): bump libp2p version * add write_all_snapshot and rework read_snapshot. * cleanup. * clippy clippy clippy clippy clippy clippy clippy clippy clippy clippy * fix(clippy): complexity & clone Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * fix(commandline): update to new signature Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * fix cli * add counter test. * add new test. * fix snapshot logic. * add todo. * The droid was excited by the meal I cooked him, until he took a byte. * clippy clip clipped Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * fix fmt Signed-off-by: Daniel Thompson-Yvetot <denjell@mailscript.com> * add forth actor and fix test. * feat(target): arm-unknown-linux-gnueabihf target for usbarmory (#90) * feat(target): arm-unknown-linux-gnueabihf target for usbarmory * add changelog * feat(client): introduce SignUnlockBlock proc (#92) * feat(client): introduce SignUnlockBlock proc * changelog * fix(fmt) * feat(client): do a proper slip10 proc * add test and fix length error. Co-authored-by: tensor-programming <tensordeveloper@gmail.com> * fix snapshot. * move tests to external folder. * move cli to examples folder. * Every year they read, "All about Robots," by Cy Borg * remove cli release workflow. * restore cli. * remove examples/commandline. * add license * add basic tests and benchmarks. * add basic test docs. * add snapshot hack. * feat(communication): refactor comms actor * fix(communication): add changelog * Refactor zone API and add documentation (#95) * Unify zone interface around a common abstract ZoneSpec type * Add some basic tests for the common zone API * Add the license_template to the runtime crate * Rewrite the runtime's README.md * typo * typo * Bump crypto.rs version (#96) iotaledger/crypto.rs@9259a06 * Snapshot docs (#84) * Remove unused code and make room for the new format documentation * Add some words about the snapshot format * Document the snapshot::files::* functions * Clearer separation of concerns regarding the snapshot paths * Add some words for the snapshot's read/write read_from/write_to functions * Expose the MAGIC and VERSION bytes (as they may be used for file type detection) * Apply suggestions from code review * Re-export the kdf:s from snapshot in the client crate * Feat/client docs (#97) * add constant locations. * add engine bench. * slip10 derive return key. * add external documentation. * add liscence. * Sy Borg, gimme dat give me the chromium leg * feat(communication): Update examples and docs * feat(communication): Adjust actor-example and docs * fix(communication): typos * Attempted fix of the SignBlockUnlock message (#103) * Correct naming in the SignUnlockBlock message * Use all available seed material when performing the SignUnlockBlock procedure * fmt :| * Fix Slip10Derive internal methods: hand back the keys * Refactor Crypto and UnlockBlock (#104) * add basic unlock block test. * fix slip10 derive. * cleanup zone warnings * fix basic test. * fix crypto logic. * add bee test. * reinsert keys. * add bee logic. * add bee-p logic and path. * remove slip10 from test case. * Sy Borg, gimme dat, gimme dat * It looks just like a TeleFunken you-47 * chore(release) (#105) * chore(release) * fix(cli): release on push to main * fix typo * fix(runtime): allow dead code * release title "Saint Malo" * fix(changelog): Alpha Release (#106) LGTM * apply version updates (#86) Co-authored-by: Daniel Thompson-Yvetot * fix(cargo) (#107) Signed-off-by: Daniel Thompson-Yvetot Co-authored-by: tensor-programming <tensordeveloper@gmail.com> Co-authored-by: elenaf9 <57632201+elenaf9@users.noreply.github.com> Co-authored-by: elenaf9 <elena.frank@protonmail.com> Co-authored-by: Gustav Behm <rootmos@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Patch libp2p version from
v0.28tov0.32.Links to any relevant issues
fixes issue #73
Type of change