[api] fix estimateGas panic for StakeMigrate (#4320)

Co-authored-by: dustinxie <dahuaxie@gmail.com>
iotexproject · Jul 2, 2024 · 05a4405 · 05a4405
1 parent 6c7e207
commit 05a4405
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/api/coreservice.go b/api/coreservice.go
@@ -1500,6 +1500,21 @@ func (core *coreService) EstimateGasForNonExecution(actType action.Action) (uint
 
 // EstimateMigrateStakeGasConsumption estimates gas consumption for migrate stake action
 func (core *coreService) EstimateMigrateStakeGasConsumption(ctx context.Context, ms *action.MigrateStake, caller address.Address) (uint64, error) {
+	g := core.bc.Genesis()
+	header, err := core.bc.BlockHeaderByHeight(core.bc.TipHeight())
+	if err != nil {
+		return 0, err
+	}
+	zeroAddr, err := address.FromString(address.ZeroAddress)
+	if err != nil {
+		return 0, err
+	}
+	ctx = protocol.WithBlockCtx(ctx, protocol.BlockCtx{
+		BlockHeight:    header.Height() + 1,
+		BlockTimeStamp: header.Timestamp().Add(g.BlockInterval),
+		GasLimit:       g.BlockGasLimitByHeight(header.Height() + 1),
+		Producer:       zeroAddr,
+	})
 	exec, err := staking.FindProtocol(core.registry).ConstructExecution(ctx, ms, core.sf)
 	if err != nil {
 		return 0, err

diff --git a/e2etest/native_staking_test.go b/e2etest/native_staking_test.go
@@ -949,6 +949,21 @@ func TestCandidateTransferOwnership(t *testing.T) {
 					&accountExpect{identityset.Address(stakerID), "99989899999999999996125955", test.nonceMgr[identityset.Address(stakerID).String()]},
 				},
 			},
+			{
+				name: "estimateGas",
+				act:  &actionWithTime{mustNoErr(action.SignedCreateStake(test.nonceMgr.pop(identityset.Address(stakerID).String()), "cand1", stakeAmount.String(), stakeDurationDays, true, nil, gasLimit, gasPrice, identityset.PrivateKey(stakerID), action.WithChainID(chainID))), stakeTime},
+				expect: []actionExpect{&functionExpect{func(test *e2etest, act *action.SealedEnvelope, receipt *action.Receipt, err error) {
+					ms, err := action.NewMigrateStake(0, 3, gasLimit, gasPrice)
+					require.NoError(err)
+					resp, err := test.api.EstimateActionGasConsumption(context.Background(), &iotexapi.EstimateActionGasConsumptionRequest{
+						Action:        &iotexapi.EstimateActionGasConsumptionRequest_StakeMigrate{StakeMigrate: ms.Proto()},
+						CallerAddress: identityset.Address(3).String(),
+						GasPrice:      gasPrice.String(),
+					})
+					require.NoError(err)
+					require.Equal(uint64(194934), resp.Gas)
+				}}},
+			},
 		})
 	})
 	t.Run("new endorsement", func(t *testing.T) {