add TODOs

action/protocol/execution/evm/evm.go

@@ -280,6 +280,7 @@ func ExecuteContract(
 			sharedGasFee, totalGasFee *big.Int
 		)
 		if ps.featureCtx.SharedGasWithDapp && sgd != nil {
+			// TODO: sgd is whether nil should be checked in processSGD
 			receiver, sharedGas, err = processSGD(ctx, sm, execution, consumedGas, sgd)
 			if err != nil {
 				return nil, nil, errors.Wrap(err, "failed to process Sharing of Gas-fee with DApps")
@@ -638,6 +639,7 @@ func SimulateExecution(
 	)
 
 	ctx = protocol.WithFeatureCtx(ctx)
+	// TODO: move the logic out of SimulateExecution
 	helperCtx := mustGetHelperCtx(ctx)
 	ctx = WithHelperCtx(ctx, HelperContext{
 		GetBlockHash: helperCtx.GetBlockHash,

action/protocol/poll/consortium.go

@@ -294,6 +294,7 @@ func getContractReaderForGenesisStates(ctx context.Context, sm protocol.StateMan
 			return nil, err
 		}
 
+		// TODO: move to the caller, then getBlockHash param can be removed
 		ctx = evm.WithHelperCtx(ctx, evm.HelperContext{
 			GetBlockHash: getBlockHash,
 		})

api/coreservice.go

@@ -1734,6 +1734,7 @@ func (core *coreService) Track(ctx context.Context, start time.Time, method stri
 }
 
 func (core *coreService) simulateExecution(ctx context.Context, addr address.Address, exec *action.Execution, getBlockHash evm.GetBlockHash) ([]byte, *action.Receipt, error) {
+	// TODO: add depositGas
 	ctx = evm.WithHelperCtx(ctx, evm.HelperContext{
 		GetBlockHash: getBlockHash,
 	})

chainservice/builder.go

@@ -618,6 +618,7 @@ func (builder *Builder) registerRollDPoSProtocol() error {
 				return nil, err
 			}
 
+			// TODO: add depositGas
 			ctx = evm.WithHelperCtx(ctx, evm.HelperContext{
 				GetBlockHash: dao.GetBlockHash,
 			})