Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The syscall.SYS_EXIT constant is not defined on Windows #1

Closed
simonerom opened this issue Apr 21, 2018 · 5 comments
Closed

The syscall.SYS_EXIT constant is not defined on Windows #1

simonerom opened this issue Apr 21, 2018 · 5 comments

Comments

@simonerom
Copy link
Member

simonerom commented Apr 21, 2018 •
edited
Loading

If you plan to support Windows OS in the future, I found that the server builds well, except that the SYS_EXIT constant used in syscall.Exit() is not defined on Windows.

I quickly fixed that with syscall.Exit(60), though I'm not a Go developer therefore a more suitable replacement is probably available.
@guo
Copy link
Member

guo commented Apr 21, 2018

Thanks for opening the first issue! 😄
Good suggestion. We don't support Windows yet. Good to know it builds well there except for a constant definition.

@simonerom
Copy link
Member Author

My pleasure to be the first contributor too ;)
Keep up the good work!

@FishMeat
Copy link
Contributor

wow~

@raullenchai
Copy link
Member

We should remove "syscall.Exit". Prefer log.Fatal.

@zjshen14
Copy link
Contributor

Fixed in: 7fac6df

saitofun added a commit that referenced this issue May 30, 2024
@saitofun
[ioctl][ioid][#1] ioid sub commands (#4284)
d4ab547 
* feat(ioctl/ioid): ioctl support ioid interactions

* chore: remove redundent abis

* fix: transfer amount flag type change to string
dustinxie pushed a commit that referenced this issue May 30, 2024
@saitofun @dustinxie
[ioctl][ioid][#1] ioid sub commands (#4284)
c39e507 
* feat(ioctl/ioid): ioctl support ioid interactions

* chore: remove redundent abis

* fix: transfer amount flag type change to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@guo @raullenchai @FishMeat @simonerom @zjshen14