[action] remove redundant errors.New() #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
commented
Mar 16, 2022
| ErrGasLimit = errors.New("exceeds block gas limit") | ||
| ErrOversizedData = errors.New("oversized data") | ||
| ErrNilProto = errors.New("empty action proto to load") | ||
| ErrNilAction = errors.New("nil action to load proto") |
There was a problem hiding this comment.
the error text is self-explanatory, so remove the comment
dustinxie
commented
Mar 16, 2022
| @@ -36,7 +36,7 @@ func TestLoadErrorDescription(t *testing.T) { | |||
| {ErrAddress, ErrAddress.Error()}, | |||
| {ErrNegativeValue, ErrNegativeValue.Error()}, | |||
| {ErrNilAction, "Unknown"}, | |||
| {ErrEmptyActionPool, "Unknown"}, | |||
| {ErrNilProto, "Unknown"}, | |||
There was a problem hiding this comment.
the name is a typo, should be Proto not ActionPool
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
=======================================
Coverage 74.95% 74.95%
=======================================
Files 227 227
Lines 21205 21205
=======================================
Hits 15895 15895
Misses 4471 4471
Partials 839 839
Continue to review full report at Codecov.
|
CoderZhi
approved these changes
Mar 16, 2022
Liuhaai
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.