-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[db] Fix variadic interface bug #3568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3568 +/- ##
==========================================
- Coverage 75.43% 74.09% -1.35%
==========================================
Files 247 254 +7
Lines 22845 23379 +534
==========================================
+ Hits 17233 17322 +89
- Misses 4685 5132 +447
+ Partials 927 925 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
db/batch/batch_impl.go
Outdated
@@ -270,7 +270,7 @@ func (cb *cachedBatch) Delete(namespace string, key []byte, errorFormat string, | |||
h := cb.hash(namespace, key) | |||
cb.touchKey(h) | |||
cb.currentCache().Evict(&h) | |||
cb.kvStoreBatch.batch(Delete, namespace, key, nil, errorFormat, errorArgs) | |||
cb.kvStoreBatch.batch(Delete, namespace, key, nil, errorFormat, errorArgs...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is prob not the complete fix, need to also change errorArgs
to []interface{}
, and use errorArgs...
when it is used in WriteBatch
see 010f0d0 (also not complete, just demo the fix on baseKVStoreBatch
)
* fix variadic interface bug * replace errorFormat with errorMessage
Description
Fixes #3517
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: