-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Use of weak random number generator #3578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3578 +/- ##
==========================================
- Coverage 75.43% 74.12% -1.32%
==========================================
Files 247 255 +8
Lines 22845 23415 +570
==========================================
+ Hits 17233 17356 +123
- Misses 4685 5134 +449
+ Partials 927 925 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
for ; n < len(p); n++ { | ||
p[n] = byte(Uint32()) | ||
} | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optimize to fill 4 bytes for every Uint32()
call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Description
fix weak random in api and blocksync
Fixes #3537
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: