Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove config in evm and pool #3611

Merged
merged 2 commits into from
Aug 25, 2022
Merged

remove config in evm and pool #3611

merged 2 commits into from
Aug 25, 2022

Conversation

millken
Copy link
Contributor

@millken millken commented Aug 24, 2022

Description

#3504 pre-fix, for resolve import cycle

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@millken millken requested a review from a team as a code owner August 24, 2022 09:56
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #3611 (b997911) into master (a20e489) will decrease coverage by 1.13%.
The diff coverage is 70.03%.

❗ Current head b997911 differs from pull request most recent head 511d0ba. Consider uploading reports for the commit 511d0ba to get more accurate results

@@            Coverage Diff             @@
##           master    #3611      +/-   ##
==========================================
- Coverage   75.43%   74.29%   -1.14%     
==========================================
  Files         247      259      +12     
  Lines       22845    23536     +691     
==========================================
+ Hits        17233    17487     +254     
- Misses       4685     5123     +438     
+ Partials      927      926       -1     
Impacted Files Coverage Δ
action/action_deserializer.go 57.14% <ø> (ø)
action/protocol/poll/nativestaking.go 41.08% <0.00%> (-0.65%) ⬇️
action/protocol/poll/staking_command.go 10.71% <0.00%> (ø)
action/protocol/staking/read_state.go 15.38% <0.00%> (ø)
action/protocol/vote/probationlist.go 87.50% <ø> (ø)
api/blocklistener.go 70.73% <0.00%> (ø)
api/websocket.go 5.17% <0.00%> (-0.19%) ⬇️
blockchain/block/block_deserializer.go 71.15% <ø> (ø)
blockchain/blockchain.go 0.89% <0.00%> (ø)
blockchain/filedao/filedao_legacy.go 85.80% <ø> (ø)
... and 104 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@millken millken changed the title remove config in evm remove config in evm and pool Aug 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@millken millken merged commit 4638ec0 into iotexproject:master Aug 25, 2022
@millken millken deleted the issue3541-evm branch August 25, 2022 05:03
dustinxie pushed a commit that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants