[evm] support opBasefee #3643
Merged
[evm] support opBasefee #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3643 +/- ##
==========================================
- Coverage 74.95% 74.78% -0.17%
==========================================
Files 269 269
Lines 23819 23881 +62
==========================================
+ Hits 17854 17860 +6
- Misses 5039 5093 +54
- Partials 926 928 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Liuhaai
reviewed
Sep 21, 2022
action/protocol/execution/evm/evm.go
Outdated
| BlockNumber: new(big.Int).SetUint64(blkCtx.BlockHeight), | ||
| Time: new(big.Int).SetInt64(blkCtx.BlockTimeStamp.Unix()), | ||
| Difficulty: new(big.Int).SetUint64(uint64(50)), | ||
| GasLimit: gasLimit, | ||
| BaseFee: new(big.Int).SetUint64(1), // in units of 10^-6 IOTX, current basefee is 1 |
There was a problem hiding this comment.
see https://eips.ethereum.org/EIPS/eip-3198
it is for contract to access the basefee
There was a problem hiding this comment.
ok. Why is it hardcoded to 1?
|
Kudos, SonarCloud Quality Gate passed!
|
raullenchai
approved these changes
Sep 22, 2022
Liuhaai
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EIP3198 is enabled in London EVM, which accesses
evm.Context.BaseFee. See ethereum/go-ethereum@94451c2#diff-c21870801ba3133fda5991da046fbfd0f83999bda1008a4af84affca83ec5eb9R171Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: