add precommit #3660
Closed
add precommit #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3660 +/- ##
==========================================
- Coverage 74.95% 74.63% -0.33%
==========================================
Files 269 266 -3
Lines 23819 23782 -37
==========================================
- Hits 17854 17750 -104
- Misses 5039 5104 +65
- Partials 926 928 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dustinxie
reviewed
Oct 11, 2022
| return clone | ||
| } | ||
|
|
||
| func (cb *candBase) Commit(change *candChange) (int, error) { |
There was a problem hiding this comment.
all funcs of candBase are private now, let's use commit() to be consistent?
There was a problem hiding this comment.
do not understand why a private struct needs to have private functions
dustinxie
reviewed
Oct 11, 2022
| @@ -435,7 +439,27 @@ func (cb *candBase) all() CandidateList { | |||
| return list | |||
| } | |||
|
|
|||
| func (cb *candBase) commit(change *candChange) (int, error) { | |||
| func (cb *candBase) Clone() *candBase { | |||
dustinxie
reviewed
Oct 11, 2022
| if err := ws.store.Commit(); err != nil { | ||
| return err | ||
| } | ||
| if err := protocolCommit(ctx, ws); err != nil { | ||
| // TODO (zhi): wrap the error and eventually panic it in caller side |
There was a problem hiding this comment.
could you pls file an issue? can be fixed in next hard-fork
raullenchai
approved these changes
Oct 11, 2022
|
this code has been integrated into (#3661), so close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interface PreCommitter. Protocols which are PreCommitter will be called before a workingset commit.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: