Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staking] save owner list after PersistStakingPatchBlock #3671

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

dustinxie
Copy link
Member

Description

as title

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dustinxie dustinxie requested a review from a team as a code owner October 16, 2022 16:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #3671 (26c59f1) into master (e9732a1) will decrease coverage by 0.52%.
The diff coverage is 64.33%.

@@            Coverage Diff             @@
##           master    #3671      +/-   ##
==========================================
- Coverage   74.95%   74.43%   -0.53%     
==========================================
  Files         269      269              
  Lines       23819    23929     +110     
==========================================
- Hits        17854    17812      -42     
- Misses       5039     5182     +143     
- Partials      926      935       +9     
Impacted Files Coverage Δ
action/protocol/protocol.go 0.00% <ø> (ø)
action/protocol/staking/candidate_center_extra.go 0.00% <0.00%> (ø)
action/protocol/staking/candidate_statemanager.go 98.59% <ø> (+1.36%) ⬆️
blockchain/config.go 74.54% <ø> (ø)
db/config.go 100.00% <ø> (ø)
db/trie/mptrie/node.go 100.00% <ø> (ø)
ioctl/newcmd/action/action.go 89.09% <ø> (+9.55%) ⬆️
ioctl/newcmd/node/nodedelegate.go 70.19% <0.00%> (-0.95%) ⬇️
ioctl/newcmd/node/nodeprobationlist.go 90.90% <0.00%> (-4.33%) ⬇️
server/itx/server.go 60.00% <25.00%> (-2.21%) ⬇️
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dustinxie dustinxie merged commit ee04a05 into master Oct 17, 2022
@dustinxie dustinxie deleted the mapfix branch October 17, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants