Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] panic when writing db returns no space #3686

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

huof6829
Copy link
Contributor

@huof6829 huof6829 commented Nov 4, 2022

Description

Split #3664 into two parts. First remove monitor, Second check writing-db.

Fixes #3629

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #3686 (d725b86) into master (263ff82) will decrease coverage by 0.74%.
The diff coverage is 89.15%.

@@            Coverage Diff             @@
##           master    #3686      +/-   ##
==========================================
- Coverage   74.47%   73.72%   -0.75%     
==========================================
  Files         269      276       +7     
  Lines       23925    24142     +217     
==========================================
- Hits        17818    17799      -19     
- Misses       5174     5438     +264     
+ Partials      933      905      -28     
Impacted Files Coverage Δ
db/db_bolt.go 68.53% <0.00%> (-3.60%) ⬇️
ioctl/newcmd/action/actiontransfer.go 100.00% <ø> (ø)
ioctl/newcmd/action/stake2withdraw.go 95.74% <ø> (ø)
ioctl/newcmd/action/xrc20transferfrom.go 100.00% <ø> (ø)
ioctl/newcmd/did/didgethash.go 100.00% <ø> (ø)
ioctl/newcmd/did/didgeturi.go 100.00% <ø> (ø)
server/itx/server.go 62.20% <ø> (+2.20%) ⬆️
action/protocol/staking/handlers.go 74.47% <33.33%> (-0.64%) ⬇️
ioctl/newcmd/did/didgenerate.go 85.71% <85.71%> (ø)
ioctl/newcmd/action/actionclaim.go 100.00% <100.00%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -396,6 +407,9 @@ func (b *BoltDB) Insert(name []byte, key uint64, value []byte) error {
}
}
if err != nil {
if errors.Is(err, syscall.ENOSPC) {
log.L().Fatal("Failed to insert db.", zap.Error(err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add into Remove() and Purge() func

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. fixed.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dustinxie dustinxie merged commit c5d9761 into iotexproject:master Nov 11, 2022
@huof6829 huof6829 deleted the check_db_write branch December 29, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic if no space is left
3 participants