-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[db] panic when writing db returns no space #3686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3686 +/- ##
==========================================
- Coverage 74.47% 73.72% -0.75%
==========================================
Files 269 276 +7
Lines 23925 24142 +217
==========================================
- Hits 17818 17799 -19
- Misses 5174 5438 +264
+ Partials 933 905 -28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -396,6 +407,9 @@ func (b *BoltDB) Insert(name []byte, key uint64, value []byte) error { | |||
} | |||
} | |||
if err != nil { | |||
if errors.Is(err, syscall.ENOSPC) { | |||
log.L().Fatal("Failed to insert db.", zap.Error(err)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add into Remove() and Purge()
func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. fixed.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Split #3664 into two parts. First remove monitor, Second check writing-db.
Fixes #3629
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: