Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] web3 rewarding read api #3693

Merged
merged 4 commits into from
Nov 30, 2022
Merged

[api] web3 rewarding read api #3693

merged 4 commits into from
Nov 30, 2022

Conversation

ququzone
Copy link
Contributor

Description

Read APIs for web3 rewarding

Fixes #3682

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ququzone ququzone requested a review from a team as a code owner November 14, 2022 00:57
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #3693 (413d01c) into master (263ff82) will decrease coverage by 0.74%.
The diff coverage is 85.05%.

❗ Current head 413d01c differs from pull request most recent head 7dea0ce. Consider uploading reports for the commit 7dea0ce to get more accurate results

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage   74.47%   73.73%   -0.75%     
==========================================
  Files         269      280      +11     
  Lines       23925    24241     +316     
==========================================
+ Hits        17818    17873      +55     
- Misses       5174     5454     +280     
+ Partials      933      914      -19     
Impacted Files Coverage Δ
api/web3server.go 28.03% <0.00%> (-34.07%) ⬇️
db/db_bolt.go 68.53% <0.00%> (-3.60%) ⬇️
ioctl/newcmd/action/actiontransfer.go 100.00% <ø> (ø)
ioctl/newcmd/action/stake2withdraw.go 95.74% <ø> (ø)
ioctl/newcmd/action/xrc20transferfrom.go 100.00% <ø> (ø)
ioctl/newcmd/did/didgethash.go 100.00% <ø> (ø)
ioctl/newcmd/did/didgeturi.go 100.00% <ø> (ø)
server/itx/server.go 62.20% <ø> (+2.20%) ⬆️
action/protocol/staking/handlers.go 74.47% <33.33%> (-0.64%) ⬇️
...tion/protocol/rewarding/ethabi/unclaimedbalance.go 80.64% <80.64%> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ququzone ququzone merged commit 663c991 into master Nov 30, 2022
@ququzone ququzone deleted the web3_rewarding_read branch November 30, 2022 13:34
@ququzone ququzone restored the web3_rewarding_read branch November 30, 2022 14:32
@ququzone ququzone deleted the web3_rewarding_read branch November 30, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web3 support rewarding actions
3 participants