[staking] remove unnecessary call from GetStakingStateReader #3695
Conversation
| height: height, | ||
| view: view, | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
protocol.Start() calls CreateBaseView() and after that the view will be written, so there's no need to check and call CreateBaseView() again here. In other words, if error happens sth is wrong
There was a problem hiding this comment.
in this case, do we still need to keep this function?
Codecov Report
@@ Coverage Diff @@
## master #3695 +/- ##
==========================================
- Coverage 74.47% 73.70% -0.78%
==========================================
Files 269 276 +7
Lines 23925 24135 +210
==========================================
- Hits 17818 17788 -30
- Misses 5174 5440 +266
+ Partials 933 907 -26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -123,18 +123,6 @@ func (c *candSR) ActiveBucketsCount() uint64 { | |||
| func GetStakingStateReader(sr protocol.StateReader) (CandidateStateReader, error) { | |||
There was a problem hiding this comment.
Replace GetStakingStateReader with ConstructBaseView?
|
Kudos, SonarCloud Quality Gate passed!
|
Description
as title
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: