Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rewarding] fix error check position #3704

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[rewarding] fix error check position #3704

merged 1 commit into from
Dec 2, 2022

Conversation

dustinxie
Copy link
Member

Description

for safety, use HF to gate the position of this error check.
After HF, this gating can be removed (that is, with the error check moved to correct position)

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dustinxie dustinxie requested a review from a team as a code owner December 2, 2022 21:44
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #3704 (2b7ff7f) into master (263ff82) will decrease coverage by 0.50%.
The diff coverage is 83.94%.

@@            Coverage Diff             @@
##           master    #3704      +/-   ##
==========================================
- Coverage   74.47%   73.97%   -0.51%     
==========================================
  Files         269      291      +22     
  Lines       23925    24697     +772     
==========================================
+ Hits        17818    18269     +451     
- Misses       5174     5495     +321     
  Partials      933      933              
Impacted Files Coverage Δ
action/protocol/staking/candidate_statereader.go 53.94% <ø> (-3.38%) ⬇️
action/protocol/types.go 0.00% <0.00%> (ø)
api/web3server.go 27.59% <0.00%> (-34.51%) ⬇️
db/db_bolt.go 68.53% <0.00%> (-3.60%) ⬇️
ioctl/newcmd/action/actiontransfer.go 100.00% <ø> (ø)
ioctl/newcmd/action/stake2withdraw.go 95.74% <ø> (ø)
ioctl/newcmd/action/xrc20transferfrom.go 100.00% <ø> (ø)
ioctl/newcmd/did/didgethash.go 100.00% <ø> (ø)
ioctl/newcmd/did/didgeturi.go 100.00% <ø> (ø)
server/itx/server.go 62.20% <ø> (+2.20%) ⬆️
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Liuhaai Liuhaai merged commit cb2c5fa into master Dec 2, 2022
@dustinxie dustinxie deleted the 3704 branch December 3, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants