-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broadcast node's height info into p2p network #3744
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3744 +/- ##
==========================================
+ Coverage 74.47% 75.47% +0.99%
==========================================
Files 269 303 +34
Lines 23925 25817 +1892
==========================================
+ Hits 17818 19485 +1667
- Misses 5174 5315 +141
- Partials 933 1017 +84
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
address: privKey.PublicKey().Address().String(), | ||
} | ||
|
||
dm.broadcastTask = routine.NewRecurringTask(func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broadcastTask could be nil
when EnableBroadcastNodeInfo
is false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, i left same comment earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remain the task has an advantage that a new delegate can enable broadcast automatically without restart
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Set up a mechanism to pull other delegate nodes info if a delegate node want , in order to have a better understanding of nodes status on the chain.
Design: p2p network monitor message design
Fixes #3724
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: