Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] Clean code in handleTransfer #3761

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented Jan 12, 2023

Description

code clean

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@Liuhaai Liuhaai changed the title Clean code in handleTransfer [action] Clean code in handleTransfer Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #3761 (12650b4) into master (263ff82) will increase coverage by 0.69%.
The diff coverage is 82.54%.

❗ Current head 12650b4 differs from pull request most recent head 73425a5. Consider uploading reports for the commit 73425a5 to get more accurate results

@@            Coverage Diff             @@
##           master    #3761      +/-   ##
==========================================
+ Coverage   74.47%   75.16%   +0.69%     
==========================================
  Files         269      299      +30     
  Lines       23925    25195    +1270     
==========================================
+ Hits        17818    18939    +1121     
- Misses       5174     5282     +108     
- Partials      933      974      +41     
Impacted Files Coverage Δ
action/actctx.go 90.62% <ø> (+6.25%) ⬆️
action/action.go 82.35% <ø> (ø)
action/action_deserializer.go 57.14% <ø> (ø)
action/candidate_update.go 88.88% <0.00%> (-4.14%) ⬇️
action/consignment_transfer.go 90.41% <ø> (ø)
action/const.go 100.00% <ø> (ø)
action/execution.go 83.78% <ø> (ø)
action/grantreward.go 68.57% <ø> (ø)
action/protocol/account/protocol.go 86.90% <ø> (ø)
action/protocol/dock.go 100.00% <ø> (ø)
... and 276 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Liuhaai Liuhaai merged commit b1fa9c9 into iotexproject:master Jan 18, 2023
Liuhaai added a commit to Liuhaai/iotex-core that referenced this pull request Feb 13, 2023
* clean code in handleTransfer
* clean code in validateTransfer
dustinxie pushed a commit that referenced this pull request Feb 18, 2023
* clean code in handleTransfer
* clean code in validateTransfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants