[block] deprecate ConvertToBlockHeaderPb() #3774

millken · 2023-01-17T03:27:14Z

Description

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov · 2023-01-17T03:54:30Z

Codecov Report

Merging #3774 (9a2b2aa) into master (263ff82) will increase coverage by 0.68%.
The diff coverage is 82.69%.

❗ Current head 9a2b2aa differs from pull request most recent head 044bec3. Consider uploading reports for the commit 044bec3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3774      +/-   ##
==========================================
+ Coverage   74.47%   75.15%   +0.68%     
==========================================
  Files         269      299      +30     
  Lines       23925    25203    +1278     
==========================================
+ Hits        17818    18942    +1124     
- Misses       5174     5286     +112     
- Partials      933      975      +42

Impacted Files	Coverage Δ
action/actctx.go	`90.62% <ø> (+6.25%)`	⬆️
action/action.go	`82.35% <ø> (ø)`
action/action_deserializer.go	`57.14% <ø> (ø)`
action/candidate_update.go	`88.88% <0.00%> (-4.14%)`	⬇️
action/consignment_transfer.go	`90.41% <ø> (ø)`
action/const.go	`100.00% <ø> (ø)`
action/execution.go	`83.78% <ø> (ø)`
action/grantreward.go	`68.57% <ø> (ø)`
action/protocol/account/protocol.go	`86.90% <ø> (ø)`
action/protocol/account/transfer.go	`84.61% <ø> (ø)`
... and 276 more