[api] implement web3 API debug_traceTransaction #3779
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3779 +/- ##
==========================================
+ Coverage 74.47% 75.36% +0.89%
==========================================
Files 269 303 +34
Lines 23925 25910 +1985
==========================================
+ Hits 17818 19528 +1710
- Misses 5174 5359 +185
- Partials 933 1023 +90
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
api/coreservice.go
Outdated
| @@ -1582,3 +1587,29 @@ func (core *coreService) SyncingProgress() (uint64, uint64, uint64) { | |||
| startingHeight, currentHeight, targetHeight, _ := core.bs.SyncStatus() | |||
| return startingHeight, currentHeight, targetHeight | |||
| } | |||
|
|
|||
| // TraceTransaction returns the trace result of transaction | |||
| func (core *coreService) TraceTransaction(ctx context.Context, actHash string, config *logger.Config) (retval []byte, receipt *action.Receipt, traces *logger.StructLogger, err error) { | |||
There was a problem hiding this comment.
grpcserver.TraceTransactionStructLogs should be integrated with this func
| @@ -75,6 +80,28 @@ type ( | |||
| CurrentBlock string `json:"currentBlock"` | |||
| HighestBlock string `json:"highestBlock"` | |||
| } | |||
| structLog struct { | |||
There was a problem hiding this comment.
Yes, structLog = logger.StructLog, but logger.StructLog ignored json field storage, web3 API needs to export it
There was a problem hiding this comment.
it could be done in MarshalJSON()
There was a problem hiding this comment.
I think there is no need to implement marshalJSON here, the structLog field can already be automatically marshaled inside. use interface{} is harder to understand
|
add test for the new api |
|
add test for the code in coreservice.go |
|
SonarCloud Quality Gate failed.
|
Description
request:
response:
{ "jsonrpc": "2.0", "id": 1, "result": { "failed": false, "revert": "", "returnValue": "0x", "gas": 138478, "structLogs": [ ... { "pc": 2936, "op": 162, "gas": "0x12f3184", "gasCost": "0x2165", "memory": "0x", "memSize": 2144, "stack": [ "0x9531dc76", "0x3b8", "0x80", "0x400", "0x5a5dba0be34307952ebd93d284f8df820caa18fa80fbd2d67515fd2804c65cec", "0x462eb2b788a2fc5799f0e0f9f845187bb11fb75150d0fe10a0a932039d8f4ad9", "0x3a0", "0x4c0" ], "returnData": "0x", "storage": null, "depth": 1, "refund": 0, "opName": "LOG2", "error": "" }, { "pc": 2937, "op": 80, "gas": "0x12f101f", "gasCost": "0x2", "memory": "0x", "memSize": 2144, "stack": [ "0x9531dc76", "0x3b8", "0x80", "0x400" ], "returnData": "0x", "storage": null, "depth": 1, "refund": 0, "opName": "POP", "error": "" }, { "pc": 2938, "op": 80, "gas": "0x12f101d", "gasCost": "0x2", "memory": "0x", "memSize": 2144, "stack": [ "0x9531dc76", "0x3b8", "0x80" ], "returnData": "0x", "storage": null, "depth": 1, "refund": 0, "opName": "POP", "error": "" }, { "pc": 2939, "op": 86, "gas": "0x12f101b", "gasCost": "0x8", "memory": "0x", "memSize": 2144, "stack": [ "0x9531dc76", "0x3b8" ], "returnData": "0x", "storage": null, "depth": 1, "refund": 0, "opName": "JUMP", "error": "" }, { "pc": 952, "op": 91, "gas": "0x12f1013", "gasCost": "0x1", "memory": "0x", "memSize": 2144, "stack": [ "0x9531dc76" ], "returnData": "0x", "storage": null, "depth": 1, "refund": 0, "opName": "JUMPDEST", "error": "" }, { "pc": 953, "op": 0, "gas": "0x12f1012", "gasCost": "0x0", "memory": "0x", "memSize": 2144, "stack": [ "0x9531dc76" ], "returnData": "0x", "storage": null, "depth": 1, "refund": 0, "opName": "STOP", "error": "" } ] } }Fixes #3775
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: