[state] Remove receipt checking after runAction #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3780 +/- ##
==========================================
+ Coverage 74.47% 75.45% +0.97%
==========================================
Files 269 300 +31
Lines 23925 25413 +1488
==========================================
+ Hits 17818 19175 +1357
- Misses 5174 5255 +81
- Partials 933 983 +50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CoderZhi
approved these changes
Jan 27, 2023
Comment on lines
+735
to
+736
| err = acc.Register(reg) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
require.NoError(t, acc.Register(reg))
dustinxie
reviewed
Jan 27, 2023
| } | ||
| blkCtx.GasLimit -= receipt.GasConsumed | ||
| ctxWithBlockContext = protocol.WithBlockCtx(ctx, blkCtx) | ||
| receipts = append(receipts, receipt) |
dustinxie
reviewed
Jan 27, 2023
| @@ -160,16 +158,15 @@ func (ws *workingSet) runAction( | |||
| // Handle action | |||
| reg, ok := protocol.GetRegistry(ctx) | |||
| if !ok { | |||
| return nil, nil | |||
| return nil, errors.New("protocol is empty") | |||
There was a problem hiding this comment.
could this potentially affect fullsync of past blocks?
dustinxie
approved these changes
Jan 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Liuhaai
added a commit
to Liuhaai/iotex-core
that referenced
this pull request
Feb 13, 2023
* remove receipt checking after runAction
dustinxie
pushed a commit
that referenced
this pull request
Feb 18, 2023
* remove receipt checking after runAction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #3555
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: