Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[genesis] set Palau to activate at 04-04-2023 11pm UTC #3823

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

dustinxie
Copy link
Member

Description

as title

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • fullsync
  • [] Other test (please specify)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.5% 16.5% Duplication

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #3823 (2d368ef) into master (e1f0636) will increase coverage by 0.03%.
The diff coverage is 76.36%.

❗ Current head 2d368ef differs from pull request most recent head bda129c. Consider uploading reports for the commit bda129c to get more accurate results

@@            Coverage Diff             @@
##           master    #3823      +/-   ##
==========================================
+ Coverage   75.38%   75.41%   +0.03%     
==========================================
  Files         303      303              
  Lines       25923    26009      +86     
==========================================
+ Hits        19541    19615      +74     
- Misses       5360     5368       +8     
- Partials     1022     1026       +4     
Impacted Files Coverage Δ
api/web3server_marshal.go 93.21% <ø> (ø)
api/web3server_utils.go 69.20% <16.66%> (-3.67%) ⬇️
api/web3server.go 81.41% <87.50%> (+2.74%) ⬆️
api/coreservice.go 68.09% <88.23%> (+0.74%) ⬆️
api/serverV2.go 86.95% <100.00%> (ø)
blockchain/genesis/genesis.go 72.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dustinxie dustinxie merged commit ac75f13 into iotexproject:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants