[state] validate system action layout #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderZhi
approved these changes
Apr 3, 2023
Liuhaai
reviewed
Apr 3, 2023
state/factory/workingset.go
Outdated
| @@ -404,6 +404,40 @@ func (ws *workingSet) process(ctx context.Context, actions []action.SealedEnvelo | |||
| return ws.finalize() | |||
| } | |||
|
|
|||
| func (ws *workingSet) validateSystemActionLayout(ctx context.Context, actions []action.SealedEnvelope) error { | |||
There was a problem hiding this comment.
add the purpose as the comment for the func
Liuhaai
reviewed
Apr 3, 2023
Liuhaai
approved these changes
Apr 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #3838 +/- ##
==========================================
+ Coverage 75.38% 75.44% +0.06%
==========================================
Files 303 303
Lines 25923 26038 +115
==========================================
+ Hits 19541 19645 +104
- Misses 5360 5371 +11
Partials 1022 1022
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dustinxie
reviewed
Apr 4, 2023
CoderZhi
reviewed
Apr 4, 2023
dustinxie
reviewed
Apr 10, 2023
dustinxie
reviewed
Apr 12, 2023
dustinxie
reviewed
Apr 12, 2023
dustinxie
reviewed
Apr 12, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid missing system actions in block generation, add validation of system actions when verifying received blocks.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: