Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Enable message batching #3857

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented May 10, 2023

Description

fix #3756

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.9% 5.9% Duplication

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #3857 (f2727fe) into master (e1f0636) will decrease coverage by 0.23%.
The diff coverage is 41.99%.

❗ Current head f2727fe differs from pull request most recent head b30f136. Consider uploading reports for the commit b30f136 to get more accurate results

@@            Coverage Diff             @@
##           master    #3857      +/-   ##
==========================================
- Coverage   75.38%   75.15%   -0.23%     
==========================================
  Files         303      306       +3     
  Lines       25923    26160     +237     
==========================================
+ Hits        19541    19661     +120     
- Misses       5360     5479     +119     
+ Partials     1022     1020       -2     
Impacted Files Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) ⬇️
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
action/protocol/staking/staking_statereader.go 0.00% <0.00%> (ø)
api/web3server_marshal.go 93.21% <ø> (ø)
blockindex/sgd_indexer.go 0.00% <0.00%> (ø)
action/protocol/staking/protocol.go 60.50% <16.66%> (+0.62%) ⬆️
api/web3server_utils.go 69.20% <16.66%> (-3.67%) ⬇️
action/protocol/rewarding/fund.go 64.70% <23.07%> (-18.91%) ⬇️
... and 11 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dustinxie dustinxie merged commit f899c86 into iotexproject:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable message batching in v1.11
3 participants