[config] enforce correct chainID and enable IIP-13 at Quebec height #3866
Conversation
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc,
millken and
a team
as code owners
| @@ -416,11 +416,6 @@ func (core *coreService) SendAction(ctx context.Context, in *iotextypes.Action) | |||
| return "", err | |||
| } | |||
|
|
|||
| // reject web3 rewarding action if isn't activation feature | |||
| if err := core.validateWeb3Rewarding(selp); err != nil { | |||
There was a problem hiding this comment.
no longer needed
should be removed in #3852
| @@ -368,6 +364,7 @@ func makeTransferAction(t *testing.T, nonce uint64) action.SealedEnvelope { | |||
| SetGasLimit(tsf.GasLimit()). | |||
| SetGasPrice(tsf.GasPrice()). | |||
| SetNonce(nonce). | |||
| SetChainID(1). | |||
There was a problem hiding this comment.
hash values in test change due to this
| @@ -148,8 +148,10 @@ func (ws *workingSet) runAction( | |||
| return nil, action.ErrGasLimit | |||
| } | |||
| // Reject execution of chainID not equal the node's chainID | |||
| if err := validateChainID(ctx, elp.ChainID()); err != nil { | |||
| return nil, err | |||
| if !action.IsSystemAction(elp) { | |||
There was a problem hiding this comment.
why is the system action not being checked?
There was a problem hiding this comment.
system action always has chainID = 0, it would fail the check
system action is added by proposer, it cannot be replayed
Quebec is one of the 13 provinces of Canada |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3866 +/- ##
==========================================
+ Coverage 75.38% 75.64% +0.25%
==========================================
Files 303 318 +15
Lines 25923 27139 +1216
==========================================
+ Hits 19541 20528 +987
- Misses 5360 5558 +198
- Partials 1022 1053 +31
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: