[IIP-13] contract indexer ignore blocks lower than height of contract deployment #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
envestcc
commented
May 26, 2023
Comment on lines
354
to
370
| func BenchmarkIndexer_PutBlockBeforeContractHeight(b *testing.B) { | ||
| // Create a new Indexer with a contract height of 100 | ||
| indexer := &Indexer{contractHeight: 100} | ||
|
|
||
| // Create a mock block with a height of 50 | ||
| blk := &block.Block{} | ||
|
|
||
| // Run the benchmark | ||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| err := indexer.PutBlock(context.Background(), blk) | ||
| if err != nil { | ||
| b.Fatal(err) | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The Benchmark Report:
❯ go test -benchmem -run=^$ -bench ^BenchmarkIndexer_PutBlockBeforeContractHeight$ github.com/iotexproject/iotex-core/blockindex/contractstaking
goos: darwin
goarch: arm64
pkg: github.com/iotexproject/iotex-core/blockindex/contractstaking
BenchmarkIndexer_PutBlockBeforeContractHeight-10 522791816 2.249 ns/op 0 B/op 0 allocs/op
PASS
ok github.com/iotexproject/iotex-core/blockindex/contractstaking 1.687s
Currently, the mainnet height is approximately 23878680. The estimated time for the startup check is 23878680 * 2.249 ns = 0.0537 s. This result is acceptable
Codecov Report
@@ Coverage Diff @@
## master #3868 +/- ##
==========================================
+ Coverage 75.38% 75.63% +0.24%
==========================================
Files 303 318 +15
Lines 25923 27145 +1222
==========================================
+ Hits 19541 20530 +989
- Misses 5360 5562 +202
- Partials 1022 1053 +31
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
envestcc
force-pushed
the
staking_ignore_blocks
branch
from
0b3772a
to
ce0badb
Compare
Liuhaai
reviewed
May 26, 2023
| @@ -82,8 +82,9 @@ func defaultConfig() Genesis { | |||
| ProbationEpochPeriod: 6, | |||
| ProbationIntensityRate: 90, | |||
| UnproductiveDelegateMaxCacheSize: 20, | |||
| // TODO (iip-13): replace the following with the address on mainnet | |||
| LiquidStakingContractAddress: "io1uw3gvmhrjz5mwxpd966wxxt6fn5uuvwfpynrwj", | |||
| // TODO (iip-13): replace the following with the address and height on mainnet | |||
|
others look good to me |
Liuhaai
approved these changes
May 26, 2023
dustinxie
reviewed
May 29, 2023
| } | ||
| ) | ||
|
|
||
| // NewContractStakingIndexer creates a new contract staking indexer | ||
| func NewContractStakingIndexer(kvStore db.KVStore, contractAddr string) *Indexer { | ||
| func NewContractStakingIndexer(kvStore db.KVStore, contractAddr string, contractHeight uint64) *Indexer { |
dustinxie
reviewed
May 29, 2023
| @@ -51,11 +51,12 @@ type ( | |||
| kvstore db.KVStore // persistent storage, used to initialize index cache at startup | |||
| cache *contractStakingCache // in-memory index for clean data, used to query index data | |||
| contractAddress string // stake contract address | |||
| contractHeight uint64 // height of the contract deployment | |||
dustinxie
approved these changes
May 29, 2023
envestcc
force-pushed
the
staking_ignore_blocks
branch
from
9622f62
to
0b32065
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To optimize the startup check of the contract indexer, the main changes are as follows:
StartHeight()method to prepare to join theBlockIndexerWithStartGroupintroduced in [blockdao] introduce blockindexer with start height #3869Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: