Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] action transfer supports 0x address #3917

Merged
merged 2 commits into from
Aug 15, 2023
Merged

[ioctl] action transfer supports 0x address #3917

merged 2 commits into from
Aug 15, 2023

Conversation

millken
Copy link
Contributor

@millken millken commented Aug 9, 2023

Description

as title, this changes is not only action transfer, other commands will be supported

Fixes #3901

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3917 (c9a058f) into master (e1f0636) will increase coverage by 0.65%.
Report is 77 commits behind head on master.
The diff coverage is 73.26%.

❗ Current head c9a058f differs from pull request most recent head a1dd1b7. Consider uploading reports for the commit a1dd1b7 to get more accurate results

@@            Coverage Diff             @@
##           master    #3917      +/-   ##
==========================================
+ Coverage   75.38%   76.03%   +0.65%     
==========================================
  Files         303      327      +24     
  Lines       25923    27826    +1903     
==========================================
+ Hits        19541    21157    +1616     
- Misses       5360     5577     +217     
- Partials     1022     1092      +70     
Files Changed Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) ⬇️
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
...tion/protocol/staking/contractstake_bucket_type.go 0.00% <0.00%> (ø)
action/receipt.go 82.17% <ø> (ø)
api/grpcserver.go 86.40% <0.00%> (ø)
api/loglistener.go 25.00% <0.00%> (ø)
api/web3server_marshal.go 93.21% <ø> (ø)
api/websocket.go 4.10% <0.00%> (-1.07%) ⬇️
... and 64 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ioctl/util/util.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dustinxie dustinxie merged commit 26297f1 into iotexproject:master Aug 15, 2023
3 checks passed
@millken millken deleted the iisue3901 branch August 16, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ioctl] action transfer should work with 0x address
3 participants