[contractstaking] fix invalid delta transfer #3924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3924 +/- ##
==========================================
+ Coverage 75.38% 76.01% +0.63%
==========================================
Files 303 328 +25
Lines 25923 27859 +1936
==========================================
+ Hits 19541 21176 +1635
- Misses 5360 5590 +230
- Partials 1022 1093 +71
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -27,6 +27,7 @@ var ( | |||
| }, | |||
| deltaStateAdded: { | |||
| deltaActionModify: deltaStateAdded, | |||
| deltaActionRemove: deltaStateUnchanged, | |||
There was a problem hiding this comment.
what about deltaStateRemoved? does it need a state-transition?
There was a problem hiding this comment.
as we chatted, also need to check blkHeight == currentHeight + 1 in PutBlock()?
There was a problem hiding this comment.
what about
deltaStateRemoved? does it need a state-transition?
no valid action could be triggered on deltaStateRemoved
There was a problem hiding this comment.
as we chatted, also need to check
blkHeight == currentHeight + 1inPutBlock()?
Thx for reminding
There was a problem hiding this comment.
add a test to validate, once a bucket is deleted, i.e., deltaStateRemoved, it cannot transition to any further state (in the same block)
| @@ -121,9 +121,16 @@ func (s *Indexer) BucketTypes() ([]*BucketType, error) { | |||
|
|
|||
| // PutBlock puts a block into indexer | |||
| func (s *Indexer) PutBlock(ctx context.Context, blk *block.Block) error { | |||
| if blk.Height() < s.contractDeployHeight || blk.Height() <= s.cache.Height() { | |||
| expectHeight := s.cache.Height() + 1 | |||
|
SonarCloud Quality Gate failed.
|
Description
StakeandMergein one transaction will cause actiondeltaActionRemoveon statedeltaStateAdded, which is not allowed currently. But this scenario should be legal, so this transfer should be allowed instead.Fixes #3921
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: