[util] implement block time calculator #3951
Conversation
envestcc
changed the title
envestcc
changed the title
| return &BlockTimeCalculator{ | ||
| getBlockInterval: getBlockInterval, | ||
| getTipHeight: getTipHeight, | ||
| getHistoryBlockTime: getHistoryBlockTime, |
There was a problem hiding this comment.
check nil for 3 input funcs
| } | ||
|
|
||
| getBlockIntervalFn func(uint64) time.Duration | ||
| getTipHeightFn func() uint64 |
There was a problem hiding this comment.
nit: below get block time func may return error, should define getTipHeightFn (uint64, error) as well?
There was a problem hiding this comment.
Currently, the method TipHeight() uint64 of the blockchain does not return an error. We can keep it this way.
|
|
||
| getBlockIntervalFn func(uint64) time.Duration | ||
| getTipHeightFn func() uint64 | ||
| getHistoryblockTimeFn func(uint64) (time.Time, error) |
There was a problem hiding this comment.
i think call it getBlockTimeFn is good and clear enough?
| if err != nil { | ||
| return time.Time{}, err | ||
| } | ||
| return tipBlockTime.Add(time.Duration(height-tipHeight) * btc.getBlockInterval(height)), nil |
There was a problem hiding this comment.
heightis in the future, so should usebtc.getBlockInterval(tipHeight)- should check possible overflow of the result,
time.Durationisint64
There was a problem hiding this comment.
For 2, If it overflows, it means it will be about 300 years later, so there is no need to consider
envestcc
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3951 +/- ##
==========================================
+ Coverage 75.38% 76.18% +0.80%
==========================================
Files 303 329 +26
Lines 25923 28005 +2082
==========================================
+ Hits 19541 21335 +1794
- Misses 5360 5572 +212
- Partials 1022 1098 +76
... and 3 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Kudos, SonarCloud Quality Gate passed!
|
Description
There are several reasons for introcuding block time calculator:
It calculates the corresponding time for a given height. It supports accurate querying of historical blocks as well as prediction for future blocks. The prediction for future blocks is calculated based on the latest height and block interval.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: