Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ioctl): api endpoint version #4005

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

saitofun
Copy link
Contributor

@saitofun saitofun commented Dec 4, 2023

Description

ioctl endpoint sub command
api endpoint version

Fixes #4002

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saitofun saitofun changed the title Feat/api endpoint version feat(ioctl): api endpoint version Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 593 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (b4b3e36) 76.06%.
Report is 141 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
action/candidate_endorsement.go 0.00% 31 Missing ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
action/candidate_activate.go 0.00% 25 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/staking/endorsement.go 0.00% 21 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4005      +/-   ##
==========================================
+ Coverage   75.38%   76.06%   +0.68%     
==========================================
  Files         303      333      +30     
  Lines       25923    28367    +2444     
==========================================
+ Hits        19541    21578    +2037     
- Misses       5360     5690     +330     
- Partials     1022     1099      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ioctl bc version

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@saitofun saitofun merged commit 322388f into master Jan 9, 2024
4 of 5 checks passed
@saitofun saitofun deleted the feat/api_endpoint_version branch January 9, 2024 01:17
dustinxie pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api endpoint version
3 participants