[action] Define CandidateSelfStake Action #4007
Conversation
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4007 +/- ##
==========================================
+ Coverage 75.38% 76.25% +0.87%
==========================================
Files 303 331 +28
Lines 25923 28281 +2358
==========================================
+ Hits 19541 21567 +2026
- Misses 5360 5616 +256
- Partials 1022 1098 +76 ☔ View full report in Codecov by Sentry. |
action/candidate_selfstake.go
Outdated
| AbstractAction | ||
|
|
||
| // bucketID is the bucket index want to be changed to | ||
| bucketID uint64 |
There was a problem hiding this comment.
does it need to carry a valid endorsement for the calling delegate? otherwise how to make sure the bucket is intended (to be used) for this delegate?
There was a problem hiding this comment.
endorsement info will be recorded in db by another transaction CandidateEndorse
action/candidate_selfstake.go
Outdated
| }, | ||
| bucketID: bucketID, | ||
| } | ||
| } |
There was a problem hiding this comment.
also what about convert to/from protobuf (for storage)?
There was a problem hiding this comment.
another PR to handle web3 and grpc convertion
action/candidate_selfstake.go
Outdated
| ) | ||
|
|
||
| // CandidateSelfStake is the action to update a candidate's bucket | ||
| type CandidateSelfStake struct { |
There was a problem hiding this comment.
for clear naming, consider rename it to CandidateActivate. SelfStake refers to the self-stake bucket, which now can come from either register, or endorsement.
There was a problem hiding this comment.
same. Updating the candidate's bucket isn't indicated by the naming
envestcc
force-pushed
the
pr_defineselfstake
branch
from
5d2d6ba
to
89be7f8
Compare
|
fixed the issues before merging |
|
Description
As a part of implementation of #3981 , this pr defines the
CandidateSelfStakeaction struct to make a candidate re-selfstakedFixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: