[refactor] Add bucket validation util functions #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
changed the title
envestcc
changed the title
envestcc
force-pushed
the
pr_bucketvalid
branch
from
c1881e2
to
b51dac4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4019 +/- ##
==========================================
+ Coverage 75.38% 76.11% +0.73%
==========================================
Files 303 335 +32
Lines 25923 28525 +2602
==========================================
+ Hits 19541 21711 +2170
- Misses 5360 5716 +356
- Partials 1022 1098 +76 ☔ View full report in Codecov by Sentry. |
envestcc
force-pushed
the
pr_bucketvalid
branch
from
b51dac4
to
fc79ebf
Compare
envestcc
changed the title
millken
approved these changes
Jan 11, 2024
envestcc
force-pushed
the
pr_bucketvalid
branch
from
bc370fd
to
8adcd5b
Compare
envestcc
changed the title
dustinxie
reviewed
Jan 12, 2024
| } | ||
|
|
||
| func validateBucketStake(bucket *VoteBucket, isStaked bool) ReceiptError { | ||
| if bucket.isUnstaked() == isStaked { |
There was a problem hiding this comment.
so it returns error for isStaked = both true and false?
dustinxie
reviewed
Jan 12, 2024
| return nil | ||
| } | ||
|
|
||
| func validateBucketCandidate(bucket *VoteBucket, candidate address.Address) ReceiptError { |
dustinxie
reviewed
Jan 12, 2024
| // endorsed bucket | ||
| r.NoError(esm.Put(bktIdx, &Endorsement{ExpireHeight: endorsementNotExpireHeight})) | ||
| r.Nil(validateBucketEndorsement(esm, bkt, (true), blkHeight)) | ||
| r.ErrorContains(validateBucketEndorsement(esm, bkt, (false), blkHeight), "bucket is already endorsed") |
dustinxie
reviewed
Jan 12, 2024
| // unendorsing bucket | ||
| r.NoError(esm.Put(bktIdx, &Endorsement{ExpireHeight: blkHeight + 1})) | ||
| r.Nil(validateBucketEndorsement(esm, bkt, (true), blkHeight)) | ||
| r.ErrorContains(validateBucketEndorsement(esm, bkt, (false), blkHeight), "bucket is already endorsed") |
dustinxie
reviewed
Jan 12, 2024
| // endorse expired bucket | ||
| r.NoError(esm.Put(bktIdx, &Endorsement{ExpireHeight: blkHeight})) | ||
| r.Nil(validateBucketEndorsement(esm, bkt, (false), blkHeight)) | ||
| r.ErrorContains(validateBucketEndorsement(esm, bkt, (true), blkHeight), "bucket is not endorsed") |
dustinxie
approved these changes
Jan 12, 2024
envestcc
force-pushed
the
pr_bucketvalid
branch
from
850ed21
to
167189e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
introduce batch of util functions to validate a bucket, reducing redundant code
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: