Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ioctl): upgrade ws apis #4021

Merged
merged 1 commit into from
Jan 2, 2024
Merged

feat(ioctl): upgrade ws apis #4021

merged 1 commit into from
Jan 2, 2024

Conversation

saitofun
Copy link
Contributor

Description

upgrade w3bstream message query api

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 515 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (15e7b7a) 76.30%.
Report is 132 commits behind head on master.

❗ Current head 15e7b7a differs from pull request most recent head 888a420. Consider uploading reports for the commit 888a420 to get more accurate results

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
blockindex/sgd_indexer.go 90.30% 12 Missing and 7 partials ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
+ Coverage   75.38%   76.30%   +0.92%     
==========================================
  Files         303      330      +27     
  Lines       25923    28264    +2341     
==========================================
+ Hits        19541    21568    +2027     
- Misses       5360     5599     +239     
- Partials     1022     1097      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

type stateLog struct {
State string `json:"state"`
Time time.Time `json:"time"`
Comment string `json:"comment"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to Comment does not affect other codes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this datatype defines in w3bstream code

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@saitofun saitofun merged commit 40da6e9 into master Jan 2, 2024
3 checks passed
@saitofun saitofun deleted the feat/upgrade_ws_api branch January 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants