-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace with sort.Slice #4034
Merged
Merged
Replace with sort.Slice #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderZhi
requested review from
dustinxie,
Liuhaai,
millken and
a team
as code owners
December 22, 2023 07:24
CoderZhi
force-pushed
the
improve_code
branch
from
January 16, 2024 10:08
1d19014
to
03a619c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4034 +/- ##
==========================================
+ Coverage 75.38% 76.19% +0.81%
==========================================
Files 303 337 +34
Lines 25923 28684 +2761
==========================================
+ Hits 19541 21856 +2315
- Misses 5360 5725 +365
- Partials 1022 1103 +81 ☔ View full report in Codecov by Sentry. |
millken
approved these changes
Jan 16, 2024
Liuhaai
approved these changes
Jan 16, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
dustinxie
pushed a commit
that referenced
this pull request
Jan 29, 2024
* mute some user request related logs * delete unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4033, delete unnecessary struct
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: