Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ioctl): ipfs endpoint and ipfs gateway config #4038

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

saitofun
Copy link
Contributor

@saitofun saitofun commented Dec 26, 2023

Description

add IPFS endpoint and gateway config

Fixes #(issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 532 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (5c7e6d4) 76.25%.
Report is 135 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
blockindex/sgd_indexer.go 90.30% 12 Missing and 7 partials ⚠️
... and 30 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
+ Coverage   75.38%   76.25%   +0.87%     
==========================================
  Files         303      331      +28     
  Lines       25923    28302    +2379     
==========================================
+ Hits        19541    21582    +2041     
- Misses       5360     5619     +259     
- Partials     1022     1101      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saitofun saitofun force-pushed the feat/ioctl_ipfs_config branch 2 times, most recently from 604e471 to 6383d7f Compare December 26, 2023 12:13
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

21.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@saitofun saitofun merged commit ef7053a into master Jan 3, 2024
3 of 5 checks passed
@saitofun saitofun deleted the feat/ioctl_ipfs_config branch January 3, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants