feat(ioctl): project register contract addr config #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitofun
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4039 +/- ##
==========================================
+ Coverage 75.38% 76.26% +0.88%
==========================================
Files 303 331 +28
Lines 25923 28288 +2365
==========================================
+ Hits 19541 21573 +2032
- Misses 5360 5617 +257
- Partials 1022 1098 +76 ☔ View full report in Codecov by Sentry. |
dustinxie
reviewed
Dec 29, 2023
ioctl/cmd/ws/wsproject.go
Outdated
| config.TranslateInLang(_flagProjectRegisterContractAddressUsages, config.UILanguage), | ||
| ) | ||
| _ = wsProject.MarkFlagRequired("contract-address") | ||
| wsProjectRegisterContractAddress = config.ReadConfig.WsProjectRegisterContract |
There was a problem hiding this comment.
why this one is special, get value from config.ReadConfig
dustinxie
reviewed
Dec 29, 2023
ioctl/config/config.go
Outdated
| @@ -69,6 +69,8 @@ type Config struct { | |||
| AnalyserEndpoint string `json:"analyserEndpoint" yaml:"analyserEndpoint"` | |||
| // WsEndpoint w3bstream endpoint | |||
| WsEndpoint string `json:"wsEndpoint" yaml:"wsEndpoint"` | |||
| // WsProjectRegisterContract w3bstream project register contract address | |||
| WsProjectRegisterContract string `json:"wsProjectRegisterContract" yaml:"wsProjectRegisterContract"` | |||
There was a problem hiding this comment.
nit: just make it simple WsRegisterContract?
dustinxie
approved these changes
Dec 29, 2023
saitofun
force-pushed
the
feat/ioctl_contract_address_config
branch
from
75b9f49
to
3afc065
Compare
huangzhiran
approved these changes
Jan 3, 2024
| @@ -28,12 +28,14 @@ const ( | |||
| _endpointPattern = "(" + _ipPattern + "|(" + _domainPattern + ")" + "|(" + _localPattern + "))" + `(:\d{1,5})?` | |||
| _defaultAnalyserEndpoint = "https://iotex-analyser-api-mainnet.chainanalytics.org" | |||
| _defaultWsEndpoint = "sprout-staging.w3bstream.com:9000" | |||
| // _defaultProjectRegisterContract default project register contract address | |||
| _defaultProjectRegisterContract = "0x4F7e678B0203e0444E17512108dba4B08B39512e" | |||
There was a problem hiding this comment.
register a new contract, for the "0x4F7e678B0203e0444E17512108dba4B08B39512e" contains much localhost uri
| @@ -35,12 +35,14 @@ const ( | |||
| _defaultAnalyserEndpoint = "https://iotex-analyser-api-mainnet.chainanalytics.org" | |||
| _defaultWsEndpoint = "sprout-staging.w3bstream.com:9000" | |||
| _defaultConfigFileName = "config.default" | |||
| // _defaultWsProjectRegisterContract default w3bstream project register contract address | |||
| _defaultWsProjectRegisterContract = "0x4F7e678B0203e0444E17512108dba4B08B39512e" | |||
saitofun
force-pushed
the
feat/ioctl_contract_address_config
branch
from
3afc065
to
812160b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
project register contract address config
Fixes #(issue)
Type of change
How Has This Been Tested?
Checklist: