feat(ioctl): use ipfs cid as project config url #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitofun
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4053 +/- ##
==========================================
+ Coverage 75.38% 76.11% +0.73%
==========================================
Files 303 335 +32
Lines 25923 28525 +2602
==========================================
+ Hits 19541 21711 +2170
- Misses 5360 5716 +356
- Partials 1022 1098 +76 ☔ View full report in Codecov by Sentry. |
CoderZhi
reviewed
Jan 15, 2024
ioctl/cmd/ws/wsproject.go
Outdated
| @@ -227,6 +226,5 @@ func upload(endpoint string, filename, hashstr string) (string, hash.Hash256, er | |||
| return "", hash.ZeroHash256, errors.Wrap(err, errUploadProjectConfigFailed.Error()) | |||
| } | |||
|
|
|||
| // generate fetch url | |||
| return fmt.Sprintf("%s/ipfs/%s", wsProjectIPFSGatewayEndpoint, cid), hash256b, nil | |||
| return cid, hash256b, nil | |||
There was a problem hiding this comment.
return fmt.Sprintf("ipfs://%x", cid), hash256b, nil
CoderZhi
approved these changes
Jan 16, 2024
hunshenshi
approved these changes
Jan 16, 2024
|
dustinxie
pushed a commit
that referenced
this pull request
Jan 29, 2024
* feat(ioctl): use ipfs cid as project config url * feat: ipfs url with endpoint and cid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use CID as project config url, instead of gateway http url
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: