Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change default ws register contract address #4054

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

saitofun
Copy link
Contributor

Description

change default ws register contract address

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 579 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (434c638) 76.20%.
Report is 153 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
api/coreservice.go 62.37% 33 Missing and 5 partials ⚠️
api/web3server.go 79.11% 30 Missing and 3 partials ⚠️
action/candidate_endorsement.go 0.00% 31 Missing ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
action/candidate_activate.go 0.00% 25 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
... and 35 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4054      +/-   ##
==========================================
+ Coverage   75.38%   76.20%   +0.81%     
==========================================
  Files         303      337      +34     
  Lines       25923    28685    +2762     
==========================================
+ Hits        19541    21858    +2317     
- Misses       5360     5724     +364     
- Partials     1022     1103      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
100.0% Duplication on New Code

See analysis details on SonarCloud

@saitofun saitofun merged commit 373d094 into master Jan 16, 2024
4 of 5 checks passed
@saitofun saitofun deleted the chore/default_ws_register_contract_addr branch January 16, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants