Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(contractstaking): add unit tests #4126

Merged
merged 2 commits into from
Feb 28, 2024
Merged

test(contractstaking): add unit tests #4126

merged 2 commits into from
Feb 28, 2024

Conversation

saitofun
Copy link
Contributor

@saitofun saitofun commented Feb 1, 2024

Description

Fixes #4123

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.39%. Comparing base (e1f0636) to head (715f0b2).
Report is 177 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4126      +/-   ##
==========================================
+ Coverage   75.38%   76.39%   +1.01%     
==========================================
  Files         303      339      +36     
  Lines       25923    28868    +2945     
==========================================
+ Hits        19541    22053    +2512     
- Misses       5360     5716     +356     
- Partials     1022     1099      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@CoderZhi CoderZhi merged commit 174f4d1 into master Feb 28, 2024
4 of 5 checks passed
@CoderZhi CoderZhi deleted the feat/iss4123 branch February 28, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests for blockindex/contractstaking/cache.go
3 participants