Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add test for actionByPrice #4135

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Feb 7, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4106

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 551 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (2910f0e) 76.31%.
Report is 172 commits behind head on master.

Files Patch % Lines
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
api/coreservice.go 63.24% 37 Missing and 6 partials ⚠️
action/candidate_endorsement.go 0.00% 31 Missing ⚠️
api/web3server.go 80.50% 29 Missing and 2 partials ⚠️
action/protocol/staking/protocol.go 45.09% 28 Missing ⚠️
action/candidate_activate.go 0.00% 25 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
+ Coverage   75.38%   76.31%   +0.93%     
==========================================
  Files         303      339      +36     
  Lines       25923    28871    +2948     
==========================================
+ Hits        19541    22034    +2493     
- Misses       5360     5730     +370     
- Partials     1022     1107      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@envestcc envestcc merged commit 5b52415 into iotexproject:master Feb 8, 2024
2 of 5 checks passed
@envestcc envestcc deleted the pr-4106 branch February 8, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests for actpool/actioniterator/actioniterator.go
3 participants