-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] Web3 for CandidateActivate and CandidateEndorsement #4140
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4140 +/- ##
==========================================
+ Coverage 75.38% 76.15% +0.77%
==========================================
Files 303 340 +37
Lines 25923 29055 +3132
==========================================
+ Hits 19541 22126 +2585
- Misses 5360 5828 +468
- Partials 1022 1101 +79 ☔ View full report in Codecov by Sentry. |
action/staking_contract.abi
Outdated
"stateMutability": "nonpayable", | ||
"type": "function" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a newline
action/action_abi.go
Outdated
stakingContractABI abi.ABI | ||
|
||
candidateActivateMethod abi.Method | ||
candidateEndorsementMethod abi.Method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break this file into candidate_activate.go
and candidate_endorsement.go
, just like other staking actions?
or move the ABI part in other staking actions into this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to put all staking-related ABIs into one file, as this will detect conflicts between different parts of the ABI.
And added TODOs to move other parts into this file in other PRs
Quality Gate failedFailed conditions |
Description
This pull request adds support for the web3 in the candidateActivate and candidateEndorsement actions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: