Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests for rlp_tx.go #4145

Merged
merged 5 commits into from
Feb 28, 2024
Merged

update tests for rlp_tx.go #4145

merged 5 commits into from
Feb 28, 2024

Conversation

millken
Copy link
Contributor

@millken millken commented Feb 20, 2024

Description

Increase test coverage

Fixes #4104

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (e1f0636) to head (61f6031).
Report is 176 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4145      +/-   ##
==========================================
+ Coverage   75.38%   76.36%   +0.98%     
==========================================
  Files         303      339      +36     
  Lines       25923    28855    +2932     
==========================================
+ Hits        19541    22035    +2494     
- Misses       5360     5718     +358     
- Partials     1022     1102      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -399,6 +399,24 @@ var (
}
)

func TestIssue4104(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the func name is casual

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@millken millken merged commit c4db3e2 into iotexproject:master Feb 28, 2024
3 of 5 checks passed
@millken millken deleted the issue4104 branch February 28, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests for action/rlp_tx.go
3 participants