-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ioctl]node reward unclaimed support name query #4150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4150 +/- ##
==========================================
+ Coverage 75.38% 76.38% +1.00%
==========================================
Files 303 340 +37
Lines 25923 28964 +3041
==========================================
+ Hits 19541 22125 +2584
- Misses 5360 5731 +371
- Partials 1022 1108 +86 ☔ View full report in Codecov by Sentry. |
ioctl/cmd/node/nodedelegate.go
Outdated
@@ -365,3 +365,16 @@ func getAllStakingCandidates(chainClient iotexapi.APIServiceClient) (candidateLi | |||
} | |||
return | |||
} | |||
|
|||
func getCandidateRewardAddressByName(cli iotexapi.APIServiceClient, name string) (string, bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getCandidateRewardAddressByAddressOrName() (string, error)
- move
address, err := util.Address(arg)
into here
ioctl/cmd/node/nodereward.go
Outdated
@@ -24,8 +24,8 @@ import ( | |||
// Multi-language support | |||
var ( | |||
_rewardCmdUses = map[config.Language]string{ | |||
config.English: "reward unclaimed|pool [ALIAS|DELEGATE_ADDRESS]", | |||
config.Chinese: "reward 未支取|奖金池 [别名|委托地址]", | |||
config.English: "reward unclaimed|pool [ALIAS|DELEGATE_ADDRESS|NAME]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|REWARD_ADDRESS
奖励地址
Quality Gate failedFailed conditions |
Co-authored-by: dustinxie <dahuaxie@gmail.com>
Description
Improve user experience, you can use
ioctl node reward unclaimed cobo
to query without input the address.Fixes #4149
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: